Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve service contract events #563

Merged
merged 1 commit into from
Jan 2, 2023
Merged

feat: improve service contract events #563

merged 1 commit into from
Jan 2, 2023

Conversation

renauter
Copy link
Collaborator

@renauter renauter marked this pull request as ready for review December 29, 2022 17:48
brandonpille
brandonpille approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@brandonpille brandonpille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.

@DylanVerstraete DylanVerstraete merged commit 2464bae into development Jan 2, 2023
@DylanVerstraete DylanVerstraete deleted the development_fix_service_contract_events branch January 2, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanVerstraete DylanVerstraete DylanVerstraete approved these changes

@brandonpille brandonpille brandonpille approved these changes

@robvanmieghem robvanmieghem Awaiting requested review from robvanmieghem

@LeeSmet LeeSmet Awaiting requested review from LeeSmet LeeSmet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renauter @brandonpille @DylanVerstraete